Retrieve latest container id from cache when sending telemetry events #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1628 +/- ##
==========================================
Coverage ? 66.68%
==========================================
Files ? 78
Lines ? 11226
Branches ? 1576
==========================================
Hits ? 7486
Misses ? 3412
Partials ? 328
Continue to review full report at Codecov.
|
narrieta
reviewed
Sep 10, 2019
narrieta
reviewed
Sep 10, 2019
pgombar
force-pushed
the
refresh_containerid
branch
from
c17db25
to
5884001
Compare
pgombar
force-pushed
the
refresh_containerid
branch
from
5884001
to
a4714e6
Compare
pgombar
changed the title
narrieta
reviewed
Sep 18, 2019
narrieta
reviewed
Sep 18, 2019
narrieta
reviewed
Sep 18, 2019
narrieta
reviewed
Sep 18, 2019
| @@ -27,6 +27,12 @@ | |||
| from azurelinuxagent.ga.exthandlers import * | |||
| from azurelinuxagent.common.protocol.wire import WireProtocol, InVMArtifactsProfile | |||
|
|
|||
| SLEEP = time.sleep | |||
There was a problem hiding this comment.
Ah sorry, I've been adding this to all my PRs ever since @larohra discovered this magical mock :) forgot to add a comment to this instance.
There was a problem hiding this comment.
Minor - Can you rename the var to MOCK_SLEEP? Only SLEEP felt like a boolean to me.
larohra
reviewed
Sep 18, 2019
larohra
approved these changes
Sep 18, 2019
pgombar
force-pushed
the
refresh_containerid
branch
from
53bcb82
to
88831b4
Compare
pgombar
force-pushed
the
refresh_containerid
branch
from
b0341b5
to
c7fbd7f
Compare
narrieta
reviewed
Sep 18, 2019
narrieta
approved these changes
Sep 18, 2019
pgombar
added a commit
to pgombar/WALinuxAgent
that referenced
this pull request
Nov 4, 2019
…y events (Azure#1628)" This reverts commit 9687794.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today, we populate a group of parameters called
vminfoonce at the start of the monitoring thread. One of these parameters isContainerIdwhich can change without redeploying the resource and restarting the agent (e.g. during live migration).Adding the functionality to fetch the
ContainerIdparameter during the construction of the telemetry event from the process environment variables. The value is set during a goal state update.PR information
Quality of Code and Contribution Guidelines
This change is